Skip to content

[release/2.14] Remove CUDA 13.4 from the binary build matrix - #8601

Merged
atalman merged 1 commit into
pytorch:release/2.14from
atalman:atalman/remove-cuda-13.4-2.14
Aug 21, 2026
Merged

[release/2.14] Remove CUDA 13.4 from the binary build matrix#8601
atalman merged 1 commit into
pytorch:release/2.14from
atalman:atalman/remove-cuda-13.4-2.14

Conversation

@atalman

@atalman atalman commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Summary

CUDA 13.4 is not shipping in the 2.14 release, so release/2.14 should not build or test it. The release channel already excluded 13.4; this drops it from the nightly and test channels too, plus the supporting arch/cudnn entries, so nothing on this branch generates a 13.4 job.

This targets release/2.14 only. The companion change for the same branch is in pytorch/pytorch.

Changes

tools/scripts/generate_binary_build_matrix.py:

Constant Change
CUDA_ARCHES_DICT drop 13.4 from nightly and test (release already lacked it)
CUDA_CUDNN_VERSIONS drop the 13.4 entry
CUDA_AARCH64_ARCHES drop 13.4-aarch64
CUDA_ARCHES_NO_WINDOWS now empty — 13.4 was its only member

Test assets regenerated for the four affected matrices. Each loses exactly the 8 CUDA 13.4 entries (one per Python version), with zero additions and zero non-13.4 removals:

Asset entries
build_matrix_linux_wheel_cuda.json 56 → 48
build_matrix_linux_wheel_cuda_norocm.json 40 → 32
build_matrix_linux_wheel_nocpu.json 48 → 40
build_matrix_linux_wheel_xpu.json 40 → 32

The macOS and Windows assets are unchanged, as expected — macOS has no CUDA builds, and 13.4 was already excluded from Windows via CUDA_ARCHES_NO_WINDOWS.

Test Plan

pytest tools/tests/test_generate_binary_build_matrix.py

Test Result

11 passed. I also diffed the regenerated assets structurally (parsed JSON, compared entry lists) to confirm every removed entry carries a 13.4/cu134 marker and nothing else changed.

Notes for the reviewer

  • tools/pkg-helpers/tests/test_cuda.py still parametrizes over 13.4. Left deliberately — it exercises version-string sanitization against an arbitrary version and has no coupling to the build matrix.
  • Two pre-existing problems in tools/tests/update_test_assets.sh that I hit and worked around rather than fix here, since they are out of scope: it invokes python (not python3), and its three --package-type conda lines fail with KeyError: 'conda' because conda support was removed from the generator. Because the redirect truncates before the command fails, running the script as-is empties the conda assets. It also emits single-line JSON while the checked-in assets are indent=2, so a naive run reformats every file. Worth a follow-up.

CUDA 13.4 is not shipping in the 2.14 release, so the release branch should
not be building or testing it. The `release` channel already excluded 13.4;
this drops it from the `nightly` and `test` channels too, along with the
supporting arch/cudnn entries, so nothing on release/2.14 generates a 13.4 job.

Changes in `tools/scripts/generate_binary_build_matrix.py`:

- `CUDA_ARCHES_DICT`: drop `13.4` from `nightly` and `test`
- `CUDA_CUDNN_VERSIONS`: drop the `13.4` entry
- `CUDA_AARCH64_ARCHES`: drop `13.4-aarch64`
- `CUDA_ARCHES_NO_WINDOWS`: now empty (13.4 was its only member)

Test assets regenerated for the four affected matrices; each loses exactly the
8 CUDA 13.4 entries (one per Python version) with no other change:

- `build_matrix_linux_wheel_cuda.json` 56 -> 48
- `build_matrix_linux_wheel_cuda_norocm.json` 40 -> 32
- `build_matrix_linux_wheel_nocpu.json` 48 -> 40
- `build_matrix_linux_wheel_xpu.json` 40 -> 32

The macOS and Windows assets are unchanged, as expected: macOS has no CUDA
builds and 13.4 was already excluded from Windows.

`tools/pkg-helpers/tests/test_cuda.py` still parametrizes over 13.4, which is
left alone deliberately -- it exercises version-string sanitization on an
arbitrary version and does not depend on the build matrix.
@vercel

vercel Bot commented Aug 21, 2026

Copy link
Copy Markdown

@atalman is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 21, 2026
@atalman
atalman merged commit c840391 into pytorch:release/2.14 Aug 21, 2026
62 of 87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: rocm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants